Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Add progress tracking to DirToUSSDirHandler for file upl… #2399

Merged

Conversation

MAVRICK-1
Copy link
Contributor

What It Does
This update enhances the DirToUSSDirHandler functionality:

  • Introduced progress tracking using commandParameters.response.progress to provide feedback during file uploads.
  • Reintroduced the encoding parameter in the upload options to ensure compatibility with various encoding configurations.

fixed #2344

How to Test

  1. Configure the handler with a valid session and set encoding in the upload options.
  2. Run the upload command with both recursive and non-recursive options.
  3. Verify that a progress bar is displayed during the upload process.
  4. Check the console log for properly formatted responses.

Review Checklist
I certify that I have:

Additional Comments
This update ensures better user feedback through progress tracking and retains support for encoding, making the handler more robust.

@MAVRICK-1
Copy link
Contributor Author

@zFernand0 can you review my PR

Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MAVRICK-1 Thanks for your contribution! Please make the requested change so the project builds successfully

@MAVRICK-1
Copy link
Contributor Author

@t1m0thyj done

@MAVRICK-1 MAVRICK-1 requested a review from t1m0thyj January 3, 2025 17:52
Copy link
Member

@t1m0thyj t1m0thyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @MAVRICK-1!

@MAVRICK-1
Copy link
Contributor Author

@t1m0thyj, I want to contribute more. Where can I learn more about developing Zowe?

@t1m0thyj
Copy link
Member

t1m0thyj commented Jan 6, 2025

@t1m0thyj, I want to contribute more. Where can I learn more about developing Zowe?

@MAVRICK-1 Zowe has several components which all welcome new contributors 🙂 You can find a summary of each one here: https://docs.zowe.org/stable/getting-started/overview

Based on your interests and programming experience, you may find some components to be more appealing than others 😋 The Zowe server components are mostly written in Java and C, and the client components are written in a variety of languages: TypeScript, Python, Kotlin, etc.

I'd also recommend joining the Open Mainframe Project Slack if you want to get more involved with the Zowe community.

Copy link
Member

@zFernand0 zFernand0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected!
LGTM! 😋

Thanks for the quick enhancement

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (7ac5ab7) to head (9145334).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2399    +/-   ##
========================================
  Coverage   91.32%   91.32%            
========================================
  Files         638      638            
  Lines       18207    18210     +3     
  Branches     3823     3931   +108     
========================================
+ Hits        16627    16630     +3     
  Misses       1579     1579            
  Partials        1        1            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@anaxceron anaxceron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment re: changelog

@@ -2,6 +2,10 @@

All notable changes to the Imperative package will be documented in this file.

## Recent Changes

- Enhancement: Added progress tracking to the `DirToUSSDirHandler` by using `commandParameters.response.progress` to show progress bars during file uploads. [#2334](https://github.com/zowe/zowe-cli/issues/2344)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should explain what DirToUSSDirHandler and commandParameters.blah.blah are: "... to the class/profile/cat/whatever DirToBlahBlah by using the commandBlahBlah function/class/cat/whatever to ..."

@t1m0thyj t1m0thyj merged commit bf77e64 into zowe:master Jan 7, 2025
15 checks passed
@t1m0thyj t1m0thyj added the release-current Indicates that there is no new functionality being delivered label Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-current Indicates that there is no new functionality being delivered
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

Fix missing progress bar on zos-files upload dir-to-uss command
6 participants