-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add progress tracking to DirToUSSDirHandler for file upl… #2399
Enhancement: Add progress tracking to DirToUSSDirHandler for file upl… #2399
Conversation
…oads Signed-off-by: MAVRICK-1 <[email protected]>
@zFernand0 can you review my PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MAVRICK-1 Thanks for your contribution! Please make the requested change so the project builds successfully
…rHandler Signed-off-by: MAVRICK-1 <[email protected]>
@t1m0thyj done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @MAVRICK-1!
@t1m0thyj, I want to contribute more. Where can I learn more about developing Zowe? |
@MAVRICK-1 Zowe has several components which all welcome new contributors 🙂 You can find a summary of each one here: https://docs.zowe.org/stable/getting-started/overview Based on your interests and programming experience, you may find some components to be more appealing than others 😋 The Zowe server components are mostly written in Java and C, and the client components are written in a variety of languages: TypeScript, Python, Kotlin, etc. I'd also recommend joining the Open Mainframe Project Slack if you want to get more involved with the Zowe community. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected!
LGTM! 😋
Thanks for the quick enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2399 +/- ##
========================================
Coverage 91.32% 91.32%
========================================
Files 638 638
Lines 18207 18210 +3
Branches 3823 3931 +108
========================================
+ Hits 16627 16630 +3
Misses 1579 1579
Partials 1 1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment re: changelog
packages/imperative/CHANGELOG.md
Outdated
@@ -2,6 +2,10 @@ | |||
|
|||
All notable changes to the Imperative package will be documented in this file. | |||
|
|||
## Recent Changes | |||
|
|||
- Enhancement: Added progress tracking to the `DirToUSSDirHandler` by using `commandParameters.response.progress` to show progress bars during file uploads. [#2334](https://github.com/zowe/zowe-cli/issues/2344) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should explain what DirToUSSDirHandler
and commandParameters.blah.blah
are: "... to the class/profile/cat/whatever DirToBlahBlah
by using the commandBlahBlah
function/class/cat/whatever to ..."
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Fernando Rijo Cedeno <[email protected]>
Signed-off-by: Timothy Johnson <[email protected]>
Quality Gate passedIssues Measures |
What It Does
This update enhances the
DirToUSSDirHandler
functionality:commandParameters.response.progress
to provide feedback during file uploads.encoding
parameter in the upload options to ensure compatibility with various encoding configurations.fixed #2344
How to Test
encoding
in the upload options.recursive
and non-recursive options.Review Checklist
I certify that I have:
Additional Comments
This update ensures better user feedback through progress tracking and retains support for encoding, making the handler more robust.